Implement NamedPipeClientStream in the unityaot profile (case 1159863) #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncham
reviewed
Jun 5, 2019
| throw new NotImplementedException (); | ||
| #else | ||
| if (IsWindows) | ||
| impl = new Win32NamedPipeClient (this, serverName, pipeName, desiredAccessRights, options, inheritability); | ||
| else | ||
| #if UNITY |
There was a problem hiding this comment.
Do you want UNITY_AOT here instead? This will affect unityjit as well.
There was a problem hiding this comment.
Oh yes, good point. I'll change these to be UNITY_AOT.
joncham
approved these changes
Jun 5, 2019
This change builds the class library code to implement the `NamedPipeClientStream` class in the unityaot profile on Windows. For the time being, we will not implement this class for non-Windows platforms, since that requires the Mono.Posix.dll assembly and a native library as well. We may consider adding support on Posix platforms in the future.
joshpeterson
force-pushed
the
named-pipes-unityaot
branch
from
4296e26
to
6ea53bf
Compare
joshpeterson
pushed a commit
that referenced
this pull request
Apr 29, 2022
In #1192 we added support for named pipes on Windows previously. This support failed to work with the unityaot-win32 profile after the most recent Mono upgrade. With this change, we will also add tests to IL2CPP to ensure that this does not break again.
6 tasks
achavakula-rythmos
pushed a commit
that referenced
this pull request
May 11, 2022
In #1192 we added support for named pipes on Windows previously. This support failed to work with the unityaot-win32 profile after the most recent Mono upgrade. With this change, we will also add tests to IL2CPP to ensure that this does not break again.
achavakula-rythmos
pushed a commit
that referenced
this pull request
May 11, 2022
In #1192 we added support for named pipes on Windows previously. This support failed to work with the unityaot-win32 profile after the most recent Mono upgrade. With this change, we will also add tests to IL2CPP to ensure that this does not break again.
This was referenced May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds the class library code to implement the
NamedPipeClientStreamclass in the unityaot profile on Windows. Forthe time being, we will not implement this class for non-Windows
platforms, since that requires the Mono.Posix.dll assembly and a native
library as well.
We may consider adding support on Posix platforms in the future.
Release notes:
IL2CPP: Add support for NamedPipeClientStream on Windows platforms. (case 1159863)
I'll backport this change to 2019.2, 2019.2, and 2018.4.